-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fixing links for website + Fixing search #16284
Fixing links for website + Fixing search #16284
Conversation
@ThomasDelteil Should we be using mxnet.incubator.apache.org or mxnet.apache.org for the links? As per https://issues.apache.org/jira/browse/INFRA-19144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16938269#comment-16938269 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes @ThomasDelteil. super crucial that we get this merged in asap and have the new website in better state for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handful of suggestions. We can hit this in multiple passes, but highlighting the https updates shined a light on how the links need tweaking...
scala-package/examples/src/main/scala/org/apache/mxnetexamples/infer/imageclassifier/README.md
Outdated
Show resolved
Hide resolved
scala-package/examples/src/main/scala/org/apache/mxnetexamples/cnntextclassification/README.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Aaron Markham <[email protected]>
@marcoabreu I don't think there's a special reason why links have been added in absolute way vs a relative way. Absolute links way makes it easier to have effective redirects, but as you mentioned they are indeed domain dependent and it becomes a problem if we test on a different domain. Relative links makes it easy to change domain. |
* first updates * fixing links + adding tutorials * fix search * fixing more links and adding new tutorials * wrong license edit * fix rendering * Apply suggestions from code review Co-Authored-By: Aaron Markham <[email protected]> * moving mxnet.incubator.apache.org to mxnet.apache.org as per Apache infra for better indexing https://issues.apache.org/jira/browse/INFRA-19144 * fixing line too long
Description