-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
@sxjscience FYI @dtracz Could you look into the CI failures? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add kernel * pseudo2dtranspose test * better calculating grid & block * add checking max sizes * test of transpose not fitting in the cuda grid * support for large tensors * estetic fixes * change iterated dimension * fix Windows issue * chane types to intex_t * fix build error
@access2rohit GPU pseudo 2d transpose |
z = mx.nd.transpose(y, axes=axes) | ||
assert_allclose(x_np, z.asnumpy().astype('uint8')) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sxjscience this removes with_seed()
from existing function. Should have been caught...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, you are right, could you make a PR to fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChaiBapchya Sorry, my bad. I should have caught this. Needs to be more careful next time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, you are right, could you make a PR to fix it?
Yes fixing it in 1 of my PRs.
Fast pseudo-2D transpose kernel.
Supports only transposes that satisfy:
Exists n and m such that:
params = (0, ..., n-1, n+m, ..., params.size, n, ..., n+m-1)
Example: (0, 2, 3, 1) or (0, 3, 1, 2), but not (0, 2, 1, 3).