Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Faster Scala NDArray to BufferedImage function #16219

Merged
merged 1 commit into from
Sep 22, 2019

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Sep 20, 2019

Description

Fixes #15123
The toImage function now runs ~85x faster on the 1024x576px Pug_cookie.jpg image.
@Chouffe

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@marcoabreu marcoabreu merged commit 37c641f into apache:master Sep 22, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@zachgk zachgk deleted the fastToImg branch October 14, 2019 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Clojure][Scala] Converting an ndarray to a BufferedImage is really slow
2 participants