Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

New ops for RCNN + old ops improvements for RCNN #16215

Merged
merged 7 commits into from
Oct 10, 2019

Conversation

Jerryzcn
Copy link
Contributor

@Jerryzcn Jerryzcn commented Sep 19, 2019

Description

  1. Box Encoder for RCNN
  2. Box Decoder for RCNN
  3. amp_multicast can cast to narrowest type now
  4. roi_align ignore rois that have batchid less than 0

Have trained mask-rcnn with the change, and the convergence is the same as before the change

seems to work now

bug fix

use template to get rid of if statement
Copy link
Member

@anirudhacharya anirudhacharya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have unit tests for box_encode and box_decode?

@Jerryzcn
Copy link
Contributor Author

can we have unit tests for box_encode and box_decode?

sure

Jerryzcn added a commit to Jerryzcn/gluon-cv that referenced this pull request Oct 3, 2019
@zhreshold zhreshold merged commit 1ab4c95 into apache:master Oct 10, 2019
Jerryzcn added a commit to Jerryzcn/gluon-cv that referenced this pull request Oct 11, 2019
Jerryzcn added a commit to dmlc/gluon-cv that referenced this pull request Oct 16, 2019
* use new ops in apache/mxnet#16215

* sampler wrap around for last part

* reduce mask head num samples

* rm reshape

fix bugs

rm redundant comment

* revert rpn_channel

revert rpn_channel

revert some change

fix typo

typo

fix typo

* fix docs

fix

fix

fix

fix

fix

fix

fix docs

fix docs

docs

docs

* fix tutorial

* fix log

* fix learning rate
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
* box encode and box decode

seems to work now

bug fix

use template to get rid of if statement

* roi align ignore batchid < 0

* amp multicast support casting to narrowest type

cpplint

cpplint

* add unittest

* address comments

* fix amp_multicast
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants