Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

removing 64 bit un-used APIs MXNDArrayLoadFromBuffer64 and MXNDArrayLoad64 #16203

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

access2rohit
Copy link
Contributor

Description

MXNDArrayLoadFromBuffer64 and MXNDArrayLoad64 do not require int64 support since their params out_size number of narray loaded. and out_name_size size of output name arrray. don't require int64

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@access2rohit
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Sep 20, 2019
@access2rohit
Copy link
Contributor Author

@apeforest @frankfliu PR is ready for review

Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeforest apeforest merged commit be7296b into apache:master Sep 20, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants