-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
56020b9
to
2df1c1d
Compare
@zachgk could you please take a quick look ^^ |
Here's the pipeline running in dev - I've just started it, so it might take some time to run to completion. |
2df1c1d
to
97d3405
Compare
Don't merge until #16202 is merged =) |
@szha he is trying to work on the migration, hope if you have some time to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where can we try to install the wheels? Can we host it in an s3 bucket for trying out first?
@szha I can see about either posting them up as artifacts (on dev) or posting them to an S3 bucket - should be fine. |
97d3405
to
a3c8c01
Compare
@perdasilva great. Let's prepare them and ask people to try them out for verification. |
Setting this to work in progress until we get community validation of the wheel files |
Here is a successful run: http://jenkins.mxnet-ci-dev.amazon-ml.com/job/restricted-mxnet-cd/job/mxnet-cd-release-job/236/ - the wheels have been posted up as artifacts. |
31a065f
to
56d6a9f
Compare
Posted up wheel files and shared them with the community. No negative feedback. Removing WIP and ready to merge =D |
Would this start publishing to all pypi package variants? As a first step, it would be prudent to limit the blast radius by publishing one package initially. |
@szha I've added changes to the pypi pipeline to skip publishing all variants except cu101 and cu101mkl - you can see an example here (I only ran the pipeline against cu100, cu101, and cu101mkl to converse resources). I decided to only skip the publish step, so we could still QA the builds for all variants. Once you are comfortable, the filter can be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couple of minor consistency suggestions in the readmes.
Since this is passing CI, I can move my review to Approved and merge (readme's can be updated later). Is it good to go now? Can we get the Pi and Nano wheels in this pipeline too? I'd love to see that! I have some notes on it and some successes, but when trying to automate the wheel creation I was getting stuck on cross-compile issues in the output wheel's platform designation. |
f54bf55
to
83696fe
Compare
@aaronmarkham I've put through some changes to the READMEs. Let's wait for @szha to merge and have final say on the variant I chose as the release one. Regarding Pi and Nano, eventually it should be possible. I guess this would just mean new variants. So, first, we would need to figure out the compilation, so the binary can be posted up to the artifact repository. Once it's there, we can update this pipeline to include it in the release. Since we already do some testing in CI, it mightn't be too difficult... |
@zachgk or anyone, could we please merge this now? |
b92f927
to
4e629d9
Compare
4e629d9
to
50952bf
Compare
Looking forward to this!! |
* Adds artifact restoration and generic pipeline to cd utils * Adds PyPI release pipeline * Adds pypi packaging fixes * Only publish cu92 and cu92mkl variants to PyPI * Updates pip package doc resources
Description
Updates the CD pipeline to include the PyPI release
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.