Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Dataset] add shard API #16175

Merged
merged 4 commits into from
Sep 18, 2019
Merged

[Dataset] add shard API #16175

merged 4 commits into from
Sep 18, 2019

Conversation

eric-haibin-lin
Copy link
Member

Description

Add an API to shard the dataset.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin
Copy link
Member Author

@davisliang

wkcn
wkcn reviewed Sep 15, 2019
View reviewed changes
python/mxnet/gluon/data/dataset.py Show resolved Hide resolved
python/mxnet/gluon/data/dataset.py Outdated Show resolved Hide resolved
wkcn
wkcn approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you: )

zhreshold
zhreshold approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@zhreshold zhreshold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eric-haibin-lin eric-haibin-lin merged commit f75d093 into apache:master Sep 18, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@eric-haibin-lin @larroy
[Dataset] add shard API (apache#16175)
7dedaa7 
* add shard API

* more balanced

* fix a bug

* Update test_gluon_data.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wkcn wkcn wkcn approved these changes

@marcoabreu marcoabreu marcoabreu left review comments

@zhreshold zhreshold zhreshold approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eric-haibin-lin @zhreshold @wkcn @marcoabreu