Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update KL Divergence formula #16170

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Update KL Divergence formula #16170

merged 2 commits into from
Sep 24, 2019

Conversation

goldmermaid
Copy link
Contributor

Errors fix.

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

python/mxnet/gluon/loss.py Outdated Show resolved Hide resolved
@sxjscience
Copy link
Member

@goldmermaid I think the 2nd change is valid, i.e., replacing pred with prob.

@goldmermaid goldmermaid reopened this Sep 24, 2019
@sxjscience sxjscience merged commit 985a4ca into apache:master Sep 24, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
* Update KL Divergence formula

Errors fix.

* remove initial error
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* Update KL Divergence formula

Errors fix.

* remove initial error
@goldmermaid goldmermaid deleted the patch-1 branch June 22, 2020 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants