Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Adds dynamic libmxnet to CD pipeline #16163

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Sep 13, 2019

Description

Extends CD pipeline to also produce the dynamically linked libmxnet and post it to the artifact repository.

Pipeline works, with the exception of the python 2 tests for the CPU variant under the statically linked library. This is a known issue and unrelated to the pipeline here. Should be ok to merge, and the fix for the failing tests can be done in a different PR/effort.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@perdasilva
Copy link
Contributor Author

@zachgk Could you please have a look?

@perdasilva perdasilva force-pushed the cd_dynamic_binary branch 2 times, most recently from f0350c1 to d989cc9 Compare September 13, 2019 18:01
@zachgk zachgk merged commit 7fc1d84 into apache:master Sep 16, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* Adds dynamic libmxnet release pipeline

* Updates default variants on CD pipeline
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants