Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Update python dependencies in more places #16137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Sep 10, 2019

Description

Updates python dependencies continuing #16105

@lanking520 @access2rohit @aaronmarkham

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zachgk zachgk mentioned this pull request Sep 10, 2019
4 tasks
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the updates on docs_requirements to its new location at https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/requirements

Python docs dependencies are set in a new environment.yml file in the python docs subfolder:
https://github.com/apache/incubator-mxnet/blob/master/docs/python_docs/environment.yml

@aaronmarkham
Copy link
Contributor

ping @zachgk

@aaronmarkham aaronmarkham added CI pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI pr-awaiting-response PR is reviewed and waiting for contributor to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants