Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Numpy eye #16132

Merged
merged 3 commits into from
Oct 12, 2019
Merged

[Numpy] Numpy eye #16132

merged 3 commits into from
Oct 12, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Sep 10, 2019

Description

Numpy eye

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@stu1130 stu1130 requested a review from szha as a code owner September 10, 2019 00:59
@stu1130 stu1130 changed the title Numpy eye [Numpy] Numpy eye Sep 10, 2019
@haojin2 haojin2 self-assigned this Sep 10, 2019
@haojin2 haojin2 requested review from reminisce and haojin2 and removed request for szha September 10, 2019 07:55
@haojin2 haojin2 added the Numpy label Sep 10, 2019
@stu1130
Copy link
Contributor Author

stu1130 commented Sep 11, 2019

@haojin2 done you can review again thanks

@haojin2 haojin2 changed the base branch from master to numpy_pr_merge October 11, 2019 21:03
@haojin2 haojin2 merged commit 753fbf1 into apache:numpy_pr_merge Oct 12, 2019
haojin2 pushed a commit that referenced this pull request Oct 12, 2019
haojin2 pushed a commit that referenced this pull request Oct 13, 2019
haojin2 pushed a commit that referenced this pull request Oct 14, 2019
reminisce pushed a commit that referenced this pull request Oct 15, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants