Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

CD Fixes #16127

Merged
merged 4 commits into from
Sep 12, 2019
Merged

CD Fixes #16127

merged 4 commits into from
Sep 12, 2019

Conversation

perdasilva
Copy link
Contributor

Description

The CD pipeline is failing due to a load library test and compiling with CUDA v8.0 support.
To mitigate these issues, I've included an environment variable to signal CD builds to the tests, thus making it more flexible to skip unneeded tests. I've also dropped building the CUDA v8.0 variant and added the CUDA v10.1 variant.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@perdasilva perdasilva force-pushed the cd_framework_static_binary_fix branch 2 times, most recently from 9c0c90a to 778add3 Compare September 10, 2019 05:49
@zachgk zachgk merged commit c5383f7 into apache:master Sep 12, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* Ignore load lib test in CD jobs

* Removes cu80 and adds cu101 support to CD builds

* Disable cython in CD python tests

* Updates CD documentation to reflect variant changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants