Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Skip coverage files find for nightly tests #16107

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

anirudh2290
Copy link
Member

Description

Skip coverage files find for nightly tests. Certain stages were assuming ENABLE_TESTCOVERAGE was on, but it has been turned off here : https://github.com/apache/incubator-mxnet/pull/15981/files#diff-1335fbaf3930b1438d9be18edb07a1a6L784

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(Verified that default value for pack_lib in Jenkinsfile_utils.groovy is false; hence we don't have to explicitly pass it to disable test coverage.)

https://github.com/apache/incubator-mxnet/blob/e98dbe776201424cff93f87e67ff3bddb87d45e5/ci/Jenkinsfile_utils.groovy#L66

Copy link
Member

@yuxihu yuxihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. LGTM.

@yuxihu yuxihu merged commit 6de6848 into apache:master Sep 6, 2019
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Sep 7, 2019
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants