Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

remove 'foo' and other print msg from test #16088

Merged
merged 3 commits into from
Sep 5, 2019
Merged

remove 'foo' and other print msg from test #16088

merged 3 commits into from
Sep 5, 2019

Conversation

apeforest
Copy link
Contributor

Description

Many messages are printed from test_profiler unit test and clogged CI output. Removing all prints from test.

samskalicky
samskalicky approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karan6181
Copy link
Contributor

LGTM. Thanks for your contribution!

yuxihu
yuxihu approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@yuxihu yuxihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like the CI is not progressing. Can you retrigger the CI? I will merge once CI passes. Thanks.

@yuxihu yuxihu merged commit c6a92d9 into apache:master Sep 5, 2019
@apeforest apeforest deleted the refactor/remove-foo branch September 5, 2019 04:35
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Sep 7, 2019
@apeforest @gyshi
remove 'foo' and other print msg from test (apache#16088)
3e3026f 
* remove 'foo' and other print msg from test

* address review comment

* re-trigger CI
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Sep 7, 2019
@apeforest @gyshi
remove 'foo' and other print msg from test (apache#16088)
d7f5c3d 
* remove 'foo' and other print msg from test

* address review comment

* re-trigger CI
@Vikas-kum
Copy link
Contributor

@apeforest This PR is causing tests to fail .
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Fwindows-cpu/detail/master/1030/pipeline/

======================================================================

FAIL: test_profiler.test_profile_task

Traceback (most recent call last):

File "C:\Python37\lib\site-packages\nose\case.py", line 198, in runTest

self.test(*self.arg)

File "C:\jenkins_slave\workspace\ut-python-cpu@2\tests\python\unittest\test_profiler.py", line 115, in test_profile_task

assert stop > start

AssertionError

======================================================================

FAIL: test_profiler.test_profile_tune_pause_resume

Traceback (most recent call last):

File "C:\Python37\lib\site-packages\nose\case.py", line 198, in runTest

self.test(*self.arg)

File "C:\jenkins_slave\workspace\ut-python-cpu@2\tests\python\unittest\test_profiler.py", line 178, in test_profile_tune_pause_resume

test_profile_task()

File "C:\jenkins_slave\workspace\ut-python-cpu@2\tests\python\unittest\test_profiler.py", line 115, in test_profile_task

assert stop > start

AssertionError

@apeforest apeforest mentioned this pull request Sep 17, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@access2rohit access2rohit access2rohit left review comments

@samskalicky samskalicky samskalicky approved these changes

@yuxihu yuxihu yuxihu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@apeforest @karan6181 @Vikas-kum @samskalicky @yuxihu @access2rohit