This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Integrate MKL-DNN leakyrelu #16075
Merged
Integrate MKL-DNN leakyrelu #16075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhennanQin
reviewed
Sep 3, 2019
TaoLv
reviewed
Sep 3, 2019
xinyu-intel
changed the title
TaoLv
reviewed
Sep 5, 2019
src/operator/leaky_relu.cc
Outdated
| const LeakyReLUParam& param = nnvm::get<LeakyReLUParam>(attrs.parsed); | ||
| if (SupportMKLDNNLeakyRelu(param, inputs[0])) { | ||
| MKLDNN_OPCHECK_INIT(true, outputs.size(), inputs, outputs); | ||
| MKLDNNLeakyReluBackward(attrs, ctx, inputs.at(0), inputs.at(1), req[0], |
There was a problem hiding this comment.
Only two inputs are needed? Is it possible to use vector so we can have a more unified interface?
There was a problem hiding this comment.
use inputs vector directly and we need first two of three NDArrays, so add a CHECK_GE(inputs, 2U). Is it make sense?
|
@xinyu-intel the MKL-DNN is updated to 0.21 now. |
|
@pengzhao-intel I'll start another PR to enable gelu after this PR merged:) |
|
@xinyu-intel is this ready to merge? |
|
yes |
|
Merging now. |
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Sep 26, 2019
* add mkldnn leakyrelu support * improve mkldnn act param * register gpu path * remove old code * trigger * fix lint and improve backward function
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* add mkldnn leakyrelu support * improve mkldnn act param * register gpu path * remove old code * trigger * fix lint and improve backward function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate
LeakyReluoperator with MKL-DNN activation primitives when theact_typeisleakyreluandelu(gelu will be available when #16073 is ready)Main Change:
LeakyReluoperator with NNVM.Activationoperator.eluandleakyrelu.conv + leakyrelufusion and quantization, which appears as a common structure in darknet and yolov3.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments