This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Speed up group executor #16069
Merged
Speed up group executor #16069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation is O(n^2), this implementation is O(n)
wkcn
reviewed
Sep 2, 2019
| for name in self.output_names] | ||
| self.num_outputs = len(self.symbol.list_outputs()) | ||
| self.num_outputs = len(self.output_names) | ||
| self.output_layouts = [i for i in range(self.num_outputs)] |
There was a problem hiding this comment.
Thank you for the contribution!
The following code may be faster : )
self.num_outputs = len(self.output_names)
self.output_layouts = [DataDesc.get_batch_axis(self.symbol[index].attr('__layout__'))
for index in range(self.num_outputs)]Current implementation is O(n^2), this implementation is O(n)
gyshi
pushed a commit
to gyshi/incubator-mxnet
that referenced
this pull request
Sep 7, 2019
* Speed up group executor Current implementation is O(n^2), this implementation is O(n) * Speed up group executor Current implementation is O(n^2), this implementation is O(n) * CI
gyshi
pushed a commit
to gyshi/incubator-mxnet
that referenced
this pull request
Sep 7, 2019
* Speed up group executor Current implementation is O(n^2), this implementation is O(n) * Speed up group executor Current implementation is O(n^2), this implementation is O(n) * CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We ran into an issue where mxnet took over 15 minutes of real-time to process large symbols, this change was the root cause. The square-brackets implementation of symbol looks up the symbol using a loop, so the implementation was O(n^2) where it should have been O(n)