Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix flaky clojure profile test #16058

Merged
merged 2 commits into from
Sep 1, 2019
Merged

Conversation

gigasquid
Copy link
Member

@gigasquid gigasquid commented Aug 31, 2019

Description

This fixes a flaky integration test from the Clojure package that was discovered in #15889 (comment).

Disabled the file test check because of the timing of the file creation was leading to flaky test results. Also removed unused test json file

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@gigasquid gigasquid mentioned this pull request Aug 31, 2019
7 tasks
@yzhliu yzhliu merged commit 36bab1c into master Sep 1, 2019
@yzhliu
Copy link
Member

yzhliu commented Sep 1, 2019

Thanks @gigasquid for quick response

zixuanweeei pushed a commit to zixuanweeei/mxnet that referenced this pull request Sep 2, 2019
* Fix flaky clojure profile test

* disable profiler test
@szha szha deleted the fix-flaky-clojure-profiler-test branch September 8, 2019 03:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants