Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

adding "total" (total time) to profiler aggregate stats sorting criteria #16055

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Aug 31, 2019

Description

Refer to the discussion in this PR.#15132
This pr is to allow users to sort the aggregate stats by "total" which is the total time spend on the operator
Also, the default sorting criterion is revised: 'avg' -> 'total'

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Zha0q1 Zha0q1 changed the title [WIP] adding "total_time" to profiler aggregate stats sorting criteria [WIP] adding "total" (total time) to profiler aggregate stats sorting criteria Aug 31, 2019
@Zha0q1 Zha0q1 changed the title [WIP] adding "total" (total time) to profiler aggregate stats sorting criteria adding "total" (total time) to profiler aggregate stats sorting criteria Aug 31, 2019
@eric-haibin-lin eric-haibin-lin merged commit 1abf05b into apache:master Sep 2, 2019
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants