This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Revert "Refactor LibraryInitializer so it's thread safe. Fixes random sporadical concurrency crashes." #16023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this was a mistake during rebase, sorry about that. |
marcoabreu
approved these changes
Aug 27, 2019
larroy
approved these changes
Aug 27, 2019
|
@marcoabreu could you please help to merge this PR? thanks |
|
@marcoabreu Could you please help me to re-trigger this PR or let me know how I can do it? thanks! |
|
@apeforest another option is not to revert the fix and just restore the CMakefile. |
|
Sure! @larroy could you please create a PR. I can merge it for you, |
7 tasks
|
#16040 already reverted the unintentional change in the original PR. So I am closing this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15762
The change in CMakeList.txt has nothing to do with the LibraryInitializer refactoring as mentioned in PR description.
The same author filed a separate PR (Add option to choose between OMP implementations #15808) to change the CMakeList.txt which was still under review and requested changes from the community.
Please strip out the change in CMakeList.txt from this PR and resubmit again. Thanks