This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[numpy][tvm] rad2deg && deg2rad #16015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haojin2
reviewed
Sep 2, 2019
python/mxnet/ndarray/numpy/_op.py
Outdated
| @@ -32,7 +32,8 @@ | |||
| 'exp', 'expm1', 'arcsin', 'arccos', 'arctan', 'sign', 'log', 'degrees', 'log2', 'log1p', | |||
| 'rint', 'radians', 'reciprocal', 'square', 'negative', 'fix', 'ceil', 'floor', | |||
| 'trunc', 'logical_not', 'arcsinh', 'arccosh', 'arctanh', 'tensordot', | |||
| 'linspace', 'expand_dims', 'tile', 'arange', 'split', 'concatenate', 'stack'] | |||
| 'linspace', 'expand_dims', 'tile', 'arange', 'split', 'concatenate', 'stack', 'deg2rad', | |||
| 'rad2deg'] | |||
There was a problem hiding this comment.
move 'deg2rad' to after 'radians' and 'rad2deg' to after 'degrees'.
There was a problem hiding this comment.
Same for the func declarations within the file
There was a problem hiding this comment.
Fixed. Thank you.
haojin2
reviewed
Sep 2, 2019
| (1, 2, 3), | ||
| (1, 0), | ||
| (2, 0, 3) | ||
| ]: |
There was a problem hiding this comment.
simply do
for shape in [(), (1,), (1, 1), (1, 2, 3), (1, 0), (2, 0, 3)]:There was a problem hiding this comment.
Have put the test into test_np_unary_funcs. Thanks.
tingying2020
force-pushed
the
np_tvm_rad2deg_deg2rad
branch
from
39e0f1e
to
a11494b
Compare
haojin2
reviewed
Sep 4, 2019
|
Almost LGTM, @yzhliu for double-check. |
tingying2020
force-pushed
the
np_tvm_rad2deg_deg2rad
branch
3 times, most recently
from
3431340
to
d74351b
Compare
tingying2020
force-pushed
the
np_tvm_rad2deg_deg2rad
branch
from
d74351b
to
36f3a21
Compare
* fix format error * change type * constangt must be tvm.const in tvm and add backward test, do not support float16 * add addto test * handle 0-dim and 0-size * add 0-dim test case * register to npi and add wrapper with doc * change function name, add infer type * fix format error * merge rad2deg to deg2rad * fix error according to review * change infer type * add TVM_OP in test
reminisce
force-pushed
the
np_tvm_rad2deg_deg2rad
branch
from
36f3a21
to
1b154ce
Compare
5 tasks
reminisce
pushed a commit
that referenced
this pull request
Sep 23, 2019
* fix format error * change type * constangt must be tvm.const in tvm and add backward test, do not support float16 * add addto test * handle 0-dim and 0-size * add 0-dim test case * register to npi and add wrapper with doc * change function name, add infer type * fix format error * merge rad2deg to deg2rad * fix error according to review * change infer type * add TVM_OP in test
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Sep 26, 2019
* fix format error * change type * constangt must be tvm.const in tvm and add backward test, do not support float16 * add addto test * handle 0-dim and 0-size * add 0-dim test case * register to npi and add wrapper with doc * change function name, add infer type * fix format error * merge rad2deg to deg2rad * fix error according to review * change infer type * add TVM_OP in test
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* fix format error * change type * constangt must be tvm.const in tvm and add backward test, do not support float16 * add addto test * handle 0-dim and 0-size * add 0-dim test case * register to npi and add wrapper with doc * change function name, add infer type * fix format error * merge rad2deg to deg2rad * fix error according to review * change infer type * add TVM_OP in test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy operator rad2deg and deg2rad implemented with tam.
@haojin2