Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Silence excessive log output in tests #15991

Closed
wants to merge 1 commit into from

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Aug 24, 2019

Description

See title.

Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to disable the output.
Currently, the subgraph fusion on CPU is on by default so could we print the message only when subgraph feature is explicitly off?

@ZhennanQin what's your opinion?

@ZhennanQin
Copy link
Contributor

This is a major change between master and v1.5, so we want to print this log to let user notice that if they have a problem on master build, they can turn off MKLDNN subgraph for a try. This log will only show once for symbol bind, so it's OK for most use case. I admitted that it's a bit annoying in CI, let's find a way to disable this in CI, not just simply quote it out for all build.

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Aug 26, 2019
@pengzhao-intel
Copy link
Contributor

@larroy friendly ping :)

@larroy
Copy link
Contributor Author

larroy commented Sep 8, 2019

Not sure what's the next action here.

@pengzhao-intel
Copy link
Contributor

Not sure what's the next action here.

Let's make it pass the CI :)

@ZhennanQin
Copy link
Contributor

#16607 is the action for this request. I guess we can close this PR if CI log is clean enough.

@pengzhao-intel
Copy link
Contributor

#16607 is the action for this request. I guess we can close this PR if CI log is clean enough.

Thanks to the great efforts @larroy @ZhennanQin, I am closing this PR now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
MKLDNN pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants