Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Disable test coverage for Clang MKLDNN #15977

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Disable test coverage for Clang MKLDNN #15977

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efb9438
disable test coverage
stu1130 Aug 22, 2019
d3585f7
disable the job
stu1130 Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/docker/runtime_functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ build_ubuntu_cpu_clang60_mkldnn() {
build_ccache_wrappers

make \
ENABLE_TESTCOVERAGE=1 \
ENABLE_TESTCOVERAGE=0 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this enough, ENABLE_TESTCOVERAGE being used in other places too ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on what I observe in PR queue, only Clang 6 with MKLDNN failed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I end up disabling the Clang 6 with MKLDNN job to avoid the situation where other task use the same function

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay thanks!

USE_CPP_PACKAGE=1 \
USE_BLAS=openblas \
USE_OPENMP=1 \
Expand Down