Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix illegal memory access bug in TBlob #15937

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Conversation

hzfan
Copy link
Contributor

@hzfan hzfan commented Aug 18, 2019

Description

Fix the illegal memory access bug in #15931 (comment)

Changes

  • Declare explicitly TBlob default copy constructor
  • Declare explicitly TBlob default assignment operator

Comments

  • This is a backward incompatible change. I'm not sure if the modification of the default behavior of TBlob copy constructor and assignment operator will affect anything.

Thank @yzhiliu and @reminisce for review and guidance.

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@reminisce reminisce merged commit 64a0502 into apache:master Aug 19, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants