Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add disable attr to subgraph property #15926

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Add disable attr to subgraph property #15926

merged 1 commit into from
Aug 17, 2019

Conversation

ZhennanQin
Copy link
Contributor

@ZhennanQin ZhennanQin commented Aug 16, 2019 •
edited
Loading

Description

Can fix the crash after export MXNET_DISABLE_MKLDNN_CONV_OPT=1

@pengzhao-intel @TaoLv @wuxun-zhang

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@ZhennanQin ZhennanQin requested a review from szha as a code owner August 16, 2019 02:58
@pengzhao-intel
Copy link
Contributor

Is there an issue to track the crash?

@ZhennanQin
Copy link
Contributor Author

@pengzhao-intel Not for now. crash is reported @wuxun-zhang . This variable isn't commonly used, so external user probably don't have this issue.

pengzhao-intel
pengzhao-intel reviewed Aug 16, 2019
View reviewed changes
src/operator/subgraph/mkldnn/mkldnn_conv_property.h
auto property = std::make_shared<SgMKLDNNConvProperty>();
property->SetAttr<std::string>("property_name", name);
property->SetAttr<bool>("inference_only", true);
if (dmlc::GetEnv("MXNET_DISABLE_MKLDNN_CONV_OPT", 0)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to handle other MXNET_DISABLE_MKLDNN_XXX environments?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested all env variables listed here, and no crash is found.

pengzhao-intel
pengzhao-intel approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pengzhao-intel
Copy link
Contributor

Thanks for the fixing and merging now.

@pengzhao-intel pengzhao-intel merged commit a8b9728 into apache:master Aug 17, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
@ZhennanQin
Add disable attr to subgraph property (apache#15926)
47fd641
@ZhennanQin ZhennanQin deleted the fix_subgraph_disable branch September 16, 2019 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wuxun-zhang wuxun-zhang wuxun-zhang left review comments

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
MKLDNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhennanQin @pengzhao-intel @wuxun-zhang