Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Remove Scala package test on build #15915

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Aug 15, 2019

Removes testing in build stage of the maven release pipeline as there is a more thorough testing stage of the pipeline
Various release build improvements to mirror pip build

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Various build improvements to mirror pip build
@zachgk zachgk merged commit c8f0b21 into apache:master Aug 16, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
Various build improvements to mirror pip build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants