This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[numpy] random.rand #15909
Closed
[numpy] random.rand #15909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xidulu
reviewed
Aug 16, 2019
python/mxnet/numpy/random.py
Outdated
| ------- | ||
| out : ndarray | ||
| A ``(d0, d1, ..., dn)``-shaped array of floating-point samples from | ||
| the standard normal distribution, or a single such float if |
There was a problem hiding this comment.
Should remove "from the standard normal".
There was a problem hiding this comment.
Will fix it. Thank You.
python/mxnet/symbol/numpy/random.py
Outdated
| ------- | ||
| out : ndarray | ||
| A ``(d0, d1, ..., dn)``-shaped array of floating-point samples from | ||
| the standard normal distribution, or a single such float if |
* fix document string -> Returns description.
|
Please rebase with current master and resolve the conflicts @kshitij12345 |
|
@haojin2 Rebase with master or numpy branch? |
reminisce
reviewed
Sep 17, 2019
reminisce
approved these changes
Oct 2, 2019
add relevant tests address comments. * fix document string -> Returns description.
reminisce
force-pushed
the
numpy-random-rand
branch
from
f051954
to
ba4373f
Compare
7 tasks
|
@reminisce @haojin2 @xidulu Sorry for the delayed action. Please review. |
xidulu
approved these changes
Oct 20, 2019
|
@kshitij12345 Thanks for your contribution. It's merged through #16554. I added missing implementation in |
|
@reminisce Oh did not notice it. Thank You. Will close this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
https://docs.scipy.org/doc/numpy-1.16.0/reference/generated/numpy.random.rand.html
Heavily Referenced from #15903
@xidulu Thank You.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes