Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] operator hypot #15901

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Conversation

tingying2020
Copy link
Contributor

numpy operator hypot
Only support float.

@haojin2

@haojin2 haojin2 added the Numpy label Aug 15, 2019
@haojin2 haojin2 self-assigned this Aug 15, 2019
@tingying2020 tingying2020 force-pushed the ms_hypot branch 2 times, most recently from 1783ed1 to bf770da Compare August 20, 2019 07:16
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@set_module('mxnet.ndarray.numpy')
def hypot(x1, x2, out=None):
r"""
hypot(x1, x2, out=None)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thank you.

@set_module('mxnet.symbol.numpy')
def hypot(x1, x2, out=None):
r"""
hypot(x1, x2, out=None)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thank you.

@Laurawly
Copy link

@tingying2020 Please fix the branch conflicts.

@reminisce reminisce changed the base branch from master to numpy_staging_prs September 23, 2019 05:14
* rebase master

* edit test

* add IsIntType to check the input type

* fix error in test

* remove hypot in doc
@reminisce reminisce merged commit b62d1c2 into apache:numpy_staging_prs Sep 23, 2019
reminisce pushed a commit that referenced this pull request Sep 23, 2019
* rebase master

* edit test

* add IsIntType to check the input type

* fix error in test

* remove hypot in doc
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
* rebase master

* edit test

* add IsIntType to check the input type

* fix error in test

* remove hypot in doc
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* rebase master

* edit test

* add IsIntType to check the input type

* fix error in test

* remove hypot in doc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants