This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tingying2020
force-pushed
the
ms_hypot
branch
2 times, most recently
from
August 20, 2019 07:16
1783ed1
to
bf770da
Compare
haojin2
reviewed
Sep 2, 2019
tingying2020
force-pushed
the
ms_hypot
branch
from
September 3, 2019 03:13
bf770da
to
dff4cf5
Compare
tingying2020
force-pushed
the
ms_hypot
branch
from
September 10, 2019 07:22
dff4cf5
to
72e68db
Compare
haojin2
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tingying2020
force-pushed
the
ms_hypot
branch
2 times, most recently
from
September 12, 2019 14:00
8f29f11
to
de56f61
Compare
Laurawly
reviewed
Sep 12, 2019
python/mxnet/ndarray/numpy/_op.py
Outdated
@set_module('mxnet.ndarray.numpy') | ||
def hypot(x1, x2, out=None): | ||
r""" | ||
hypot(x1, x2, out=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thank you.
Laurawly
reviewed
Sep 12, 2019
python/mxnet/symbol/numpy/_symbol.py
Outdated
@set_module('mxnet.symbol.numpy') | ||
def hypot(x1, x2, out=None): | ||
r""" | ||
hypot(x1, x2, out=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thank you.
tingying2020
force-pushed
the
ms_hypot
branch
2 times, most recently
from
September 16, 2019 07:53
9b42157
to
385dc5a
Compare
@tingying2020 Please fix the branch conflicts. |
tingying2020
force-pushed
the
ms_hypot
branch
from
September 17, 2019 10:46
385dc5a
to
ad02fdc
Compare
Laurawly
approved these changes
Sep 17, 2019
tingying2020
force-pushed
the
ms_hypot
branch
from
September 19, 2019 14:33
ad02fdc
to
e696934
Compare
* rebase master * edit test * add IsIntType to check the input type * fix error in test * remove hypot in doc
5 tasks
reminisce
pushed a commit
that referenced
this pull request
Sep 23, 2019
* rebase master * edit test * add IsIntType to check the input type * fix error in test * remove hypot in doc
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Sep 26, 2019
* rebase master * edit test * add IsIntType to check the input type * fix error in test * remove hypot in doc
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* rebase master * edit test * add IsIntType to check the input type * fix error in test * remove hypot in doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy operator hypot
Only support float.
@haojin2