This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Adding tests and C APIs for Large Tensors #15895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
access2rohit
requested review from
anirudh2290,
eric-haibin-lin and
szha
as code owners
August 14, 2019 22:48
@mxnet-label-bot add [pr-work-in-progress] |
access2rohit
changed the title
Adding tests to verify support for Large Tensors in additional Ops
[WIP]Adding tests to verify support for Large Tensors in additional Ops
Aug 14, 2019
access2rohit
force-pushed
the
new_lis
branch
5 times, most recently
from
August 20, 2019 01:01
210ea70
to
7a6cf75
Compare
access2rohit
changed the title
[WIP]Adding tests to verify support for Large Tensors in additional Ops
Adding tests to verify support for Large Tensors in additional Ops
Aug 20, 2019
@mxnet-label-bot add [pr-awaiting-review] |
@apeforest @ChaiBapchya this is now ready for review |
…ong with new C_Apis supporting 64bit indexing
access2rohit
changed the title
Adding tests to verify support for Large Tensors in additional Ops
Adding tests and C APIs for Large Tensors
Aug 20, 2019
access2rohit
changed the title
Adding tests and C APIs for Large Tensors
Adding tests and C APIs for Large Indices
Aug 20, 2019
access2rohit
changed the title
Adding tests and C APIs for Large Indices
Adding tests and C APIs for Large Tensors
Aug 20, 2019
apeforest
approved these changes
Aug 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ChaiBapchya could you please review? |
larroy
approved these changes
Aug 20, 2019
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
…ong with new C_Apis supporting 64bit indexing (apache#15895)
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
…ong with new C_Apis supporting 64bit indexing (apache#15895)
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
…ong with new C_Apis supporting 64bit indexing (apache#15895)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new tests to verify support for Large Tensors and new C_Apis to support 64bit indexing
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments