Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Adding tests and C APIs for Large Tensors #15895

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Aug 14, 2019

Description

Added new tests to verify support for Large Tensors and new C_Apis to support 64bit indexing

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@access2rohit
Copy link
Contributor Author

@mxnet-label-bot add [pr-work-in-progress]

@marcoabreu marcoabreu added the pr-work-in-progress PR is still work in progress label Aug 14, 2019
@access2rohit access2rohit changed the title Adding tests to verify support for Large Tensors in additional Ops [WIP]Adding tests to verify support for Large Tensors in additional Ops Aug 14, 2019
@access2rohit access2rohit changed the title [WIP]Adding tests to verify support for Large Tensors in additional Ops Adding tests to verify support for Large Tensors in additional Ops Aug 20, 2019
@access2rohit
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Aug 20, 2019
@access2rohit
Copy link
Contributor Author

@apeforest @ChaiBapchya this is now ready for review

…ong with new C_Apis supporting 64bit indexing
@access2rohit access2rohit changed the title Adding tests to verify support for Large Tensors in additional Ops Adding tests and C APIs for Large Tensors Aug 20, 2019
@access2rohit access2rohit changed the title Adding tests and C APIs for Large Tensors Adding tests and C APIs for Large Indices Aug 20, 2019
@access2rohit access2rohit changed the title Adding tests and C APIs for Large Indices Adding tests and C APIs for Large Tensors Aug 20, 2019
Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeforest
Copy link
Contributor

@ChaiBapchya could you please review?

@apeforest apeforest merged commit 308e4ac into apache:master Aug 20, 2019
access2rohit added a commit to access2rohit/incubator-mxnet that referenced this pull request Sep 25, 2019
access2rohit added a commit to access2rohit/incubator-mxnet that referenced this pull request Sep 25, 2019
access2rohit added a commit to access2rohit/incubator-mxnet that referenced this pull request Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants