Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

new 'raise' mode for nd.take and fix for backward of 'wrap' mode #15887

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Aug 14, 2019

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Raise mode for nd.take
  • Unit test coverage for 'raise'
  • Bug fix for 'wrap' mode in the backward pass
  • Unit test coverage for 'wrap'

Comments

Flakiness Check:

MXNET_TEST_COUNT=10000 nosetests tests/python/gpu/test_operator_gpu.py:test_take
[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=1953629676 to reproduce.
.
----------------------------------------------------------------------
Ran 1 test in 108.923s

OK

@haojin2 haojin2 changed the title new 'raise' mode for nd.take and fix for backward of wrap mode new 'raise' mode for nd.take and fix for backward of 'wrap' mode Aug 14, 2019
@haojin2 haojin2 self-assigned this Aug 14, 2019
@haojin2 haojin2 force-pushed the take_raise branch 4 times, most recently from e6379dd to f6ce09c Compare August 20, 2019 05:31
@eric-haibin-lin
Copy link
Member

nice!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants