Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Port several np ops to master #15867

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

reminisce
Copy link
Contributor

@reminisce reminisce commented Aug 12, 2019

Description

Ports several numpy-like ops from the numpy branch to master.

tile
repeat
expand_dims
squeeze
broadcast_to
flatten
meshgrid
prod
reshape
transpose
broadcast_arrays
arange

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Add more ops back

Add new files

Add unit tests

Add unit test for broadcast_arrays

Add more ops and tests

Add arange
@reminisce reminisce force-pushed the port_several_np_ops_to_master branch from e2cf94b to 7823f5e Compare August 13, 2019 04:21
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 39bf4e0 into apache:master Aug 13, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
* Add squeeze/flatten/transpose/reshape

Add more ops back

Add new files

Add unit tests

Add unit test for broadcast_arrays

Add more ops and tests

Add arange

* clean up
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants