This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[fix] Support nullop in transpose
#15865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrendx
approved these changes
Aug 12, 2019
TaoLv
reviewed
Aug 13, 2019
…to fix/support-nullop/transpose
apeforest
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
LGTM. @kshitij12345 thank you for your contribution. Could you please re-trigger the CI again?
|
@apeforest The pending pipelines have actually completed successfully. I guess there was an issue in notifying the Github. Do I have to retrigger it? Or is it ok this way? |
Please retrigger. We cannot merge a PR unless the CI passing is reflected to the github page. The merge button is disabled in this case. |
|
Oh. Sure. |
|
@kshitij12345 Thanks for your contribution. Merging now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15709