Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy add numpy op indices #15837

Merged
merged 3 commits into from
Sep 12, 2019
Merged

Numpy add numpy op indices #15837

merged 3 commits into from
Sep 12, 2019

Conversation

gyshi
Copy link
Contributor

@gyshi gyshi commented Aug 10, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@gyshi gyshi requested a review from szha as a code owner August 10, 2019 02:38
@haojin2 haojin2 added the Numpy label Aug 10, 2019
@haojin2 haojin2 requested review from reminisce and haojin2 and removed request for szha August 10, 2019 03:05
@haojin2 haojin2 self-assigned this Aug 10, 2019
@gyshi gyshi force-pushed the indices branch 5 times, most recently from 68f3958 to 89cf54f Compare August 15, 2019 06:39
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @gyshi Please re-trigger the CI, seems like it's stuck now.

@gyshi gyshi force-pushed the indices branch 2 times, most recently from 0dba60e to dad6521 Compare September 11, 2019 06:44
@Vikas-kum
Copy link
Contributor

backward compatibility check is failing for this PR:
Can you check this and make sure that it passes - http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-backwards-compatibility-checker/detail/restricted-backwards-compatibility-checker/778/pipeline

@haojin2
Copy link
Contributor

haojin2 commented Sep 14, 2019

@Vikas-kum Please see the actual error message on the MBCC error: OSError: libtvm_runtime.so: cannot open shared object file: No such file or directory This PR is not related to the failure, it may just happens to be the last PR merged on that day.

larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* add numpy op indices

* re-trigger ci

* fix cpplint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants