This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Making Features as a singleton for improved caching #15835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChaiBapchya @apeforest please review |
|
@mxnet-label-bot add[pr-awaiting-review] |
|
@larroy please review |
access2rohit
force-pushed
the
singleton_feature
branch
from
914667d
to
cc39360
Compare
larroy
reviewed
Aug 9, 2019
| @@ -73,6 +73,12 @@ class Features(collections.OrderedDict): | |||
| """ | |||
| OrderedDict of name to Feature | |||
| """ | |||
| instance = None | |||
access2rohit
force-pushed
the
singleton_feature
branch
from
6ace6e8
to
ecab594
Compare
access2rohit
force-pushed
the
singleton_feature
branch
from
ecab594
to
a0f50bc
Compare
|
@mxnet-label-bot add [pr-awaiting-merge] |
ChaiBapchya
approved these changes
Aug 10, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caches Features by making it singleton.
Used Approach mentioned here: https://medium.com/@mrfksiv/python-design-patterns-2-the-singleton-f995c3198c8
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Testing
ubuntu@ip-172-31-82-110 ~/incubator-mxnet (singleton_feature) $ MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/python/unittest/test_runtime.py
1
/home/ubuntu/anaconda3/lib/python3.6/site-packages/h5py/init.py:36: FutureWarning: Conversion of the second argument of issubdtype from
floattonp.floatingis deprecated. In future, it will be treated asnp.float64 == np.dtype(float).type.from ._conv import register_converters as _register_converters
test_runtime.test_features ... 2
[✖ CUDA, ✖ CUDNN, ✖ NCCL, ✖ CUDA_RTC, ✖ TENSORRT, ✔ CPU_SSE, ✔ CPU_SSE2, ✔ CPU_SSE3, ✔ CPU_SSE4_1, ✔ CPU_SSE4_2, ✖ CPU_SSE4A, ✔ CPU_AVX, ✖ CPU_AVX2, ✖ OPENMP, ✖ SSE, ✔ F16C, ✖ JEMALLOC, ✔ BLAS_OPEN, ✖ BLAS_ATLAS, ✖ BLAS_MKL, ✖ BLAS_APPLE, ✖ LAPACK, ✖ MKLDNN, ✖ OPENCV, ✖ CAFFE, ✖ PROFILER, ✖ DIST_KVSTORE, ✖ CXX14, ✔ INT64_TENSOR_SIZE, ✖ SIGNAL_HANDLER, ✔ DEBUG, ✖ TVM_OP]
ok
test_runtime.test_is_singleton ... 2
2
ok
test_runtime.test_is_enabled ... 2
ok
test_runtime.test_is_enabled_not_existing ... 2
ok
Ran 4 tests in 0.001s