Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy . add numpy op logspace #15825

Merged
merged 2 commits into from
Oct 13, 2019
Merged

Numpy . add numpy op logspace #15825

merged 2 commits into from
Oct 13, 2019

Conversation

gyshi
Copy link
Contributor

@gyshi gyshi commented Aug 9, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@gyshi gyshi requested a review from szha as a code owner August 9, 2019 13:30
@haojin2 haojin2 added the Numpy label Aug 9, 2019
@haojin2 haojin2 self-assigned this Aug 9, 2019
@haojin2 haojin2 requested review from haojin2 and reminisce and removed request for szha August 9, 2019 21:51
@gyshi
Copy link
Contributor Author

gyshi commented Sep 23, 2019

@haojin2 @reminisce thx for reviewing

tests/python/unittest/test_numpy_op.py Outdated Show resolved Hide resolved
src/operator/numpy/np_init_op.h Show resolved Hide resolved
src/operator/numpy/np_init_op.h Outdated Show resolved Hide resolved
tests/python/unittest/test_numpy_op.py Outdated Show resolved Hide resolved
@gyshi gyshi force-pushed the logspace branch 3 times, most recently from 17928c2 to c5bd98f Compare September 26, 2019 14:02
fix test files and other errors
@haojin2 haojin2 changed the base branch from master to numpy_pr_merge October 13, 2019 04:07
@haojin2 haojin2 merged commit c95de90 into apache:numpy_pr_merge Oct 13, 2019
haojin2 pushed a commit that referenced this pull request Oct 14, 2019
fix test files and other errors
reminisce pushed a commit that referenced this pull request Oct 15, 2019
fix test files and other errors
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
fix test files and other errors
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants