Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix lack of dylib support in Makefile when use lapack #15813

Merged
merged 2 commits into from
Sep 24, 2019

Conversation

hgt312
Copy link
Contributor

@hgt312 hgt312 commented Aug 9, 2019

Description

Fix lack of dylib support in Makefile when use lapack

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

Thank @yzhliu for review.

@hgt312 hgt312 requested a review from szha as a code owner August 9, 2019 03:37
@reminisce reminisce merged commit 35ef45c into apache:master Sep 24, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@hgt312 hgt312 deleted the fix-lapack-makefile branch April 10, 2020 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants