This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add power, exponent, log ops large tensor support #15794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeforest
reviewed
Aug 8, 2019
| @@ -351,6 +351,69 @@ def test_topk(): | |||
| l = nd.topk(b, k=1, axis=-1, dtype=np.int64, ret_typ="value") | |||
| assert l.sum() == np.sum(np.arange(0, SMALL_Y)) | |||
|
|
|||
| def test_exponent_logarithm_operators(): | |||
| a = 2*nd.ones(shape=(LARGE_X, SMALL_Y)) | |||
There was a problem hiding this comment.
a. create_2d_tensor uses 114G (htop reading) for the creating an nd array while same MXNet nd would do it around 40G.
b. np.arange is not really necessary. All we need to do is test if the function works for large arrays.
What do you think?
There was a problem hiding this comment.
maybe we should change create_2d_array to make it more efficient.
There was a problem hiding this comment.
yes. but ill address that in separate PR if that's fine.
There was a problem hiding this comment.
Yeah lets remove unnecessary numpy APIs from this test file if they eat up too much memory
apeforest
reviewed
Aug 8, 2019
access2rohit
approved these changes
Aug 14, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* power, exponent, log ops * lint * Trigger notification * Trigger notification * Trigger notification
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* power, exponent, log ops * lint * Trigger notification * Trigger notification * Trigger notification
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* power, exponent, log ops * lint * Trigger notification * Trigger notification * Trigger notification
access2rohit
pushed a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* power, exponent, log ops * lint * Trigger notification * Trigger notification * Trigger notification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added large tensor support to follow ops
Exponent & Log -
exp,expm1,log,log2,log10,log1pPower -
sqrt,rsqrt,cbrt,rcbrt,square,reciprocalChecklist
Essentials
Please feel free to remove inapplicable items for your PR.