Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix minor bugs in tvm #15781

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Fix minor bugs in tvm #15781

merged 1 commit into from
Aug 7, 2019

Conversation

hzfan
Copy link
Contributor

@hzfan hzfan commented Aug 7, 2019

Description

Fix minor bugs in tvm

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

Thank @yzhliu for guidance and review.

@hzfan hzfan requested a review from szha as a code owner August 7, 2019 12:54
@yzhliu yzhliu merged commit 07eb482 into apache:master Aug 7, 2019
@yzhliu
Copy link
Member

yzhliu commented Aug 7, 2019

Thanks @hzfan

anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Aug 21, 2019
(cherry picked from commit 07eb482)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants