This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoeygxy
requested review from
anirudh2290,
eric-haibin-lin and
szha
as code owners
August 6, 2019 06:32
reminisce
reviewed
Aug 6, 2019
@@ -614,6 +614,25 @@ def convert(num): | |||
range(4), | |||
range(3, 0, -1), | |||
(range(4,), [1]), | |||
# Test Ellipsis ('...') | |||
((1, Ellipsis, -1), False), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the first item of the tuple is needed in this test. Please delete all False
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks!
wkcn
reviewed
Aug 8, 2019
Still fixing autograd for zero-size tensors. |
Closing this PR now since #15942 has been merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://docs.scipy.org/doc/numpy/reference/arrays.indexing.html
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments