This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix flaky test test_global_metric #15756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoabreu
approved these changes
Aug 5, 2019
|
@wkcn Thanks for keeping retriggering the CI - data.mxnet.io is super unreliable recently. |
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* Fix flaky test test_global_metric * Retrigger CI * retrigger CI * retrigger CI * retrigger CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15592
The reason for assertion failure was that sometimes the random inputs would produce
nanas a result, which would make the comparisonm1.get() == m2.get()fail asnan != nan.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.