This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Revert "Dynamic Library Loading Support" #15755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3112893.
marcoabreu
requested review from
anirudh2290,
eric-haibin-lin and
szha
as code owners
7 tasks
|
Does it avoid the risk to build the dynamic library in CI rather than download? |
|
Yes
JackieWu <[email protected]> schrieb am Di., 6. Aug. 2019, 01:27:
… Does it avoid the risk to build the dynamic library in CI rather than
download?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15755>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEOED2Z2JNT7TLJK5BY4IZLQDCZPLANCNFSM4IJOGRHQ>
.
|
|
Maybe we can only disable the related test temporarily. |
|
Hi @mseth10 and @samskalicky , I merge this PR because of the security risk as @marcoabreu mentioned. Hope you reopen a new PR, which builds the dynamic library in CI building process : ) |
7 tasks
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* Revert "Dynamic Library Loading Support (apache#15489)" This reverts commit 3112893. * Retrigger CI * CI * retrigger CI * retrigger CI * retrigger CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15489
Reason is the fact that this change poses a security risk: https://github.com/apache/incubator-mxnet/pull/15489/files#diff-e73d371c303c4adefa9914b6c5a6db8cR36
It allows arbitrary code execution on any computer that executes unit tests. This means it's potentially harmful for our CI system as well as our users.
I will merge this PR at 7pm GMT on 8/6/2019.