Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-978] Higher Order Gradient Support clip, dropout. #15746

Merged

Conversation

kshitij12345
Copy link
Contributor

Description

PR intends to add support for higher order gradient for clip, dropout.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA-978 issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • higher order gradient for a clip, dropout.
  • unit test for the same.

@roywei
Copy link
Member

roywei commented Aug 19, 2019

@kshitij12345 could you trigger CI again?

@kshitij12345
Copy link
Contributor Author

@roywei @apeforest Have retriggered and the tests have ran successfully.

Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeforest apeforest merged commit 24f0a10 into apache:master Sep 6, 2019
@kshitij12345 kshitij12345 deleted the develop/add-higher-order/clip-dropout branch September 7, 2019 06:43
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Sep 7, 2019
…15746)

* support clip, dropout for higher order grad

* add relevant tests

* retrigger CI
gyshi pushed a commit to gyshi/incubator-mxnet that referenced this pull request Sep 7, 2019
…15746)

* support clip, dropout for higher order grad

* add relevant tests

* retrigger CI
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
…15746)

* support clip, dropout for higher order grad

* add relevant tests

* retrigger CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants