Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Allow operators with multiple outputs in get_atomic_symbol #15740

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Aug 3, 2019

Description

Fix for #15725. Previously the implementation required that number of outputs in the source symbol was 1, which is too strong requirement (as what it actually requires is that the symbol is not a symbol group). This PR fixes that to allow single symbols with multiple outputs.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Copy link
Contributor

@DickJC123 DickJC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For whatever it's worth, I have verified that this test fails on the codebase without this PR.

This PR LGTM.

@ptrendx ptrendx merged commit 24a5cf0 into apache:master Aug 13, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
)

* Allow operators with multiple outputs in get_atomic_symbol

* Added unittest
joapolarbear added a commit to joapolarbear/incubator-mxnet that referenced this pull request Oct 28, 2020
joapolarbear added a commit to joapolarbear/incubator-mxnet that referenced this pull request Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants