Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add missing default axis value to symbol.squeeze op #15707

Merged
merged 3 commits into from
Jul 31, 2019
Merged

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Jul 30, 2019

Description

Fix #15705

@leezu leezu requested a review from szha as a code owner July 30, 2019 18:36
leezu added a commit to leezu/gluon-nlp that referenced this pull request Jul 30, 2019
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a test to catch this case. Maybe add a test for HybridBlock with fluent squeeze in it?

@piyushghai
Copy link
Contributor

@mxnet-label-bot Add [pr-awaiting-review, Symbol]

@marcoabreu marcoabreu added pr-awaiting-review PR is waiting for code review Symbol labels Jul 31, 2019
@szha szha merged commit f0c69f5 into apache:master Jul 31, 2019
@leezu leezu deleted the patch-8 branch August 1, 2019 16:55
szha pushed a commit to dmlc/gluon-nlp that referenced this pull request Aug 1, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
* Add missing default arg

* Add test

* add test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review Symbol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in nightly: TypeError: squeeze() missing 1 required positional argument: 'axis'
4 participants