This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Numpy take operator implementation & bug fix in ndarray.take #15699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot Add [Numpy, Operator] |
haojin2
reviewed
Aug 5, 2019
@@ -341,6 +341,53 @@ struct Take { | |||
} | |||
}; | |||
|
|||
template<bool clip = true> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you moving device-specific kernel to .h
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you looking to share the kernels with the numpy version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you looking to share the kernels with the numpy version?
Yes, I want to reuse kernels of ndarray version.
haojin2
reviewed
Aug 5, 2019
haojin2
reviewed
Aug 5, 2019
haojin2
reviewed
Aug 5, 2019
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of numpy
take
operator in mxnet.Fix a bug that backward computation of
ndarray.take
does not check argumentmode
.The version that cherry-pick on new numpy branch, old pr -> #15567.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
take
nd.take
Comments
Welcome @reminisce, @haojin2 and others for reviewing.