Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add MKLDNN 4c layout to fix gluoncv se_resnext101_64x4d #15692

Merged
merged 2 commits into from
Aug 1, 2019

Conversation

xinyu-intel
Copy link
Contributor

Description

gluoncv ci failure after upgrade mxnet-mkl version.

dmlc/gluon-cv#863

@zhreshold @pengzhao-intel @TaoLv

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@xinyu-intel xinyu-intel changed the title Add MKLDNN 4c layout to fix gluoncv se_resnext101_64x4d [WIP]Add MKLDNN 4c layout to fix gluoncv se_resnext101_64x4d Jul 30, 2019
@zhreshold
Copy link
Member

please ping me once all ci passed

@xinyu-intel
Copy link
Contributor Author

@zhreshold CI pass:)

@xinyu-intel xinyu-intel changed the title [WIP]Add MKLDNN 4c layout to fix gluoncv se_resnext101_64x4d Add MKLDNN 4c layout to fix gluoncv se_resnext101_64x4d Jul 31, 2019
@piyushghai
Copy link
Contributor

@mxnet-label-bot Add [pr-awaiting-merge, MKLDNN]

@marcoabreu marcoabreu added MKLDNN pr-awaiting-merge Review and CI is complete. Ready to Merge labels Jul 31, 2019
@zhreshold zhreshold merged commit 811d516 into apache:master Aug 1, 2019
juliusshufan pushed a commit to juliusshufan/incubator-mxnet that referenced this pull request Aug 8, 2019
juliusshufan pushed a commit to juliusshufan/incubator-mxnet that referenced this pull request Aug 8, 2019
TaoLv pushed a commit that referenced this pull request Aug 8, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
MKLDNN pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants