Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix USE_BLAS == openblas check #15691

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Fix USE_BLAS == openblas check #15691

merged 1 commit into from
Jul 30, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Jul 30, 2019

Description

Fixes #15652

USE_BLAS is set to "openblas" not "open" when compiling with Openblas.

@larroy larroy requested a review from szha as a code owner July 30, 2019 00:47
@larroy
Copy link
Contributor Author

larroy commented Jul 30, 2019

Testing:

Verified the right preprocessor flag is passed during compilation.

g++ -std=c++11 -c -DMSHADOW_FORCE_STREAM -Wall -Wsign-compare -O3 -DNDEBUG=1 -I/home/ANT.AMAZON.COM/pllarroy/devel/mxnet_master/3rdparty/mshadow/ -I/home/ANT.AMAZON.COM/pllarroy/devel/mxnet_master/3rdparty/dmlc-core/include -fPIC -I/home/ANT.AMAZON.COM/pllarroy/devel/mxnet_master/3rdparty/tvm/nnvm/include -I/home/ANT.AMAZON.COM/pllarroy/devel/mxnet_master/3rdparty/dlpack/include -I/home/ANT.AMAZON.COM/pllarroy/devel/mxnet_master/3rdparty/tvm/include -Iinclude -funroll-loops -Wno-unused-parameter -Wno-unknown-pragmas -Wno-unused-local-typedefs -msse3 -mf16c -DMSHADOW_USE_CUDA=0 -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMSHADOW_USE_PASCAL=0 -DMXNET_USE_OPENCV=1 -I/usr/include/opencv -fopenmp -DMXNET_USE_OPERATOR_TUNING=1 -DMSHADOW_INT64_TENSOR_SIZE=0 -DMXNET_USE_BLAS_OPEN=1 -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-free -DUSE_JEMALLOC  -DMXNET_USE_NCCL=0 -DMXNET_USE_LIBJPEG_TURBO=0 -MMD -c src/operator/nn/mkldnn/mkldnn_act.cc -o build/src/operator/nn/mkldnn/mkldnn_act.o

@larroy
Copy link
Contributor Author

larroy commented Jul 30, 2019

@sa #15424

@larroy
Copy link
Contributor Author

larroy commented Jul 30, 2019

@mxnet-label-bot add [Build, Bug]

TaoLv
TaoLv approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@TaoLv TaoLv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@TaoLv TaoLv merged commit 90f881d into apache:master Jul 30, 2019
@ChaiBapchya ChaiBapchya mentioned this pull request Aug 3, 2019
Closed
3 tasks
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
@larroy
Fix USE_BLAS == openblas check (apache#15691)
c01b95d 
Fixes apache#15652
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TaoLv TaoLv TaoLv approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Bug Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using openblas
3 participants
@larroy @TaoLv @marcoabreu