Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

handle fix_gamma in tensorrt subgraph conversion correctly #15645

Merged
merged 1 commit into from
Jul 27, 2019

Conversation

haohuanw
Copy link
Contributor

@haohuanw haohuanw commented Jul 24, 2019

Description

the current nnvm->onnx->tensorrt conversion is ignoring the fix_gamma field for batch norm layer. This commit tries to solve this particular issue by providing a way to massage params map before convert nnvm to onnx.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • [ x ] Changes are complete (i.e. I finished coding on this PR)
  • [ x ] All changes have test coverage:
    • the unit test failed before and succeeded after
 a: array([[[[4.9751253]]]], dtype=float32)
 b: array([[[[0.]]]], dtype=float32)
-------------------- >> begin captured stdout << ---------------------
[[[[4.9751253]]]]
[[[[0.]]]]
--------------------- >> end captured stdout << ----------------------
----------------------------------------------------------------------
Ran 1 test in 5.820s
FAILED (failures=1)
.
----------------------------------------------------------------------
Ran 1 test in 5.513s
OK
  • [ x ] Code is well-documented:
  • [ x ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • [ x ] Add "Preprocess" step in nnvm->onnx conversion where allow modifying param map

Comments

This is a bug fix for tensor rt subgraph conversion

@haohuanw haohuanw changed the title [WIP] handle fix_gamma in tensorrt subgraph conversion correctly handle fix_gamma in tensorrt subgraph conversion correctly Jul 24, 2019
@abhinavs95
Copy link
Contributor

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Jul 24, 2019
@KellenSunderland KellenSunderland merged commit 6b22aa4 into apache:master Jul 27, 2019
KellenSunderland pushed a commit to KellenSunderland/incubator-mxnet that referenced this pull request Aug 13, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants