This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[Flaky test] Skip test_operator_gpu.test_convolution_independent_gradients #15631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoLv
reviewed
Jul 23, 2019
| # set a low bar for autotuned cudnn conv | ||
| atol = 1.0e-1 if ctx.device_type == "gpu" else 1.0e-3 | ||
| rtol = 1.0e-2 if ctx.device_type == "gpu" else 1.0e-3 | ||
| if ctx.device_type == "gpu": |
There was a problem hiding this comment.
You can set ctx = mx.cpu() explicitly to avoid testing it on GPU. Please also add description or issue link so we can revisit it in the future.
There was a problem hiding this comment.
Makes sense. I will add some notes after filing an issue.
|
@mxnet-label-bot add [test, Flaky] |
|
@TaoLv Please take some reviews on this PR again. Thanks. |
TaoLv
approved these changes
Jul 26, 2019
7 tasks
juliusshufan
pushed a commit
to juliusshufan/incubator-mxnet
that referenced
this pull request
Aug 12, 2019
…ients (apache#15631) * Skip test_convolution_independent_gradirents * Add an issue link * Fix inconsistent context of input array and binding op * Trigger CI * Retrigger CI
juliusshufan
pushed a commit
to juliusshufan/incubator-mxnet
that referenced
this pull request
Aug 12, 2019
…ients (apache#15631) * Skip test_convolution_independent_gradirents * Add an issue link * Fix inconsistent context of input array and binding op * Trigger CI * Retrigger CI
TaoLv
pushed a commit
that referenced
this pull request
Aug 13, 2019
…o weights… (#15805) * [MKLDNN] Independent gradients requests check with respect to weights and bias of convolution (#15497) * Independent req[kBias] and req[kWeight] check * Add UT for independent conv gradient requests * Update conv independent grad UT with no_bias enabled * Check req[kWeight] for avoiding unnecessary prim registration * Check `OpReqTpye` in CommitOutput automatically * Lock cudnn autotune for accurate conv output * Ignore independent gradients test on GPU * Trigger CI * Sets a low bar for autotuned cudnn convolution * [Flaky test] Skip test_operator_gpu.test_convolution_independent_gradients (#15631) * Skip test_convolution_independent_gradirents * Add an issue link * Fix inconsistent context of input array and binding op * Trigger CI * Retrigger CI
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
…ients (apache#15631) * Skip test_convolution_independent_gradirents * Add an issue link * Fix inconsistent context of input array and binding op * Trigger CI * Retrigger CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it was descibed in #15603,
test_convolution_independent_gradientshas occasional assertion error on gpu device. This PR intends to skip the unit test whenctx.device_type="gpu". @pengzhao-intel @TaoLv @ciyongchChecklist
Essentials
Changes
atol = 1e-3,rtol = 1e-3by default.Comments