Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Deprecate USE_PROFILER flag #15595

Merged
merged 2 commits into from
Jul 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ mxnet_option(USE_MKLDNN "Use MKLDNN variant of MKL (if MKL found)" ON
mxnet_option(USE_OPERATOR_TUNING "Enable auto-tuning of operators" ON IF NOT MSVC)
mxnet_option(USE_GPERFTOOLS "Build with GPerfTools support" OFF)
mxnet_option(USE_JEMALLOC "Build with Jemalloc support" ON)
mxnet_option(USE_PROFILER "Build with Profiler support" ON)
mxnet_option(USE_DIST_KVSTORE "Build with DIST_KVSTORE support" OFF)
mxnet_option(USE_PLUGINS_WARPCTC "Use WARPCTC Plugins" OFF)
mxnet_option(USE_PLUGIN_CAFFE "Use Caffe Plugin" OFF)
Expand Down
2 changes: 0 additions & 2 deletions benchmark/opperf/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ Hence, in this utility, we will build the functionality to allow users and devel

## Prerequisites

This utility uses MXNet profiler under the hood to fetch compute and memory metrics. Hence, you need to build MXNet with `USE_PROFILER=1` flag.

Make sure to build the flavor of MXNet, for example - with/without MKL, with CUDA 9 or 10.1 etc., on which you would like to measure operator performance. Finally, you need to add path to your cloned MXNet repository to the PYTHONPATH.

```
Expand Down
2 changes: 1 addition & 1 deletion docs/faq/env_var.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ $env:MXNET_STORAGE_FALLBACK_LOG_VERBOSE=0

## Control the profiler

When USE_PROFILER is enabled in Makefile or CMake, the following environments can be used to profile the application without changing code. Execution options may affect the granularity of profiling result. If you need profiling result of every operator, please set `MXNET_EXEC_BULK_EXEC_INFERENCE`, `MXNET_EXEC_BULK_EXEC_MAX_NODE_TRAIN` and `MXNET_EXEC_BULK_EXEC_TRAIN` to 0.
The following environments can be used to profile the application without changing code. Execution options may affect the granularity of profiling result. If you need profiling result of every operator, please set `MXNET_EXEC_BULK_EXEC_INFERENCE`, `MXNET_EXEC_BULK_EXEC_MAX_NODE_TRAIN` and `MXNET_EXEC_BULK_EXEC_TRAIN` to 0.

* MXNET_PROFILER_AUTOSTART
- Values: 0(false) or 1(true) ```(default=0)```
Expand Down
4 changes: 1 addition & 3 deletions docs/faq/perf.md
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,7 @@ that gives detailed information about execution time at the symbol level.
This feature complements general profiling tools like _nvprof_ and _gprof_
by summarizing at the operator level, instead of a function, kernel, or instruction level.

In order to be able to use the profiler, you must compile _MXNet_ with the `USE_PROFILER=1` flag in `config.mk`.

The profiler can then be turned on with an [environment variable](http://mxnet.io/faq/env_var.html#control-the-profiler)
The profiler can be turned on with an [environment variable](http://mxnet.io/faq/env_var.html#control-the-profiler)
for an entire program run, or programmatically for just part of a run.
See [example/profiler](https://github.com/dmlc/mxnet/tree/master/example/profiler)
for complete examples of how to use the profiler in code, but briefly, the Python code looks like:
Expand Down
1 change: 0 additions & 1 deletion docs/install/osx_setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ echo "USE_OPENCV=1" >> ./config.mk
echo "USE_OPENMP=1" >> ./config.mk
echo "USE_MKLDNN=1" >> ./config.mk
echo "USE_BLAS=apple" >> ./config.mk
echo "USE_PROFILER=1" >> ./config.mk
LIBRARY_PATH=$(brew --prefix llvm)/lib/ make -j $(sysctl -n hw.ncpu)
```

Expand Down
2 changes: 1 addition & 1 deletion docs/tutorials/mkldnn/MKLDNN_README.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ cd incubator-mxnet
### Build MXNet with MKL-DNN

```
LIBRARY_PATH=$(brew --prefix llvm)/lib/ make -j $(sysctl -n hw.ncpu) CC=$(brew --prefix llvm)/bin/clang CXX=$(brew --prefix llvm)/bin/clang++ USE_OPENCV=1 USE_OPENMP=1 USE_MKLDNN=1 USE_BLAS=apple USE_PROFILER=1
LIBRARY_PATH=$(brew --prefix llvm)/lib/ make -j $(sysctl -n hw.ncpu) CC=$(brew --prefix llvm)/bin/clang CXX=$(brew --prefix llvm)/bin/clang++ USE_OPENCV=1 USE_OPENMP=1 USE_MKLDNN=1 USE_BLAS=apple
```

<h2 id="3">Windows</h2>
Expand Down
3 changes: 1 addition & 2 deletions example/profiler/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@

This folder contains examples of using MXNet profiler to generate profiling results in json files.
Please refer to [this link](http://mxnet.incubator.apache.org/faq/perf.html?highlight=profiler#profiler)
for visualizing profiling results and make sure that you have installed a version of MXNet compiled
with `USE_PROFILER=1`.
for visualizing profiling results.

- profiler_executor.py. To run this example,
- clone mxnet-memonger (git clone https://github.com/dmlc/mxnet-memonger.git).
Expand Down
2 changes: 0 additions & 2 deletions make/maven/maven_darwin_mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1
Expand Down
3 changes: 0 additions & 3 deletions make/maven/maven_linux_cu90mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/maven/maven_linux_cu92mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/maven/maven_linux_mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_darwin_cpu.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_darwin_mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cpu.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu100.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu100mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu101.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu101mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu75.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu75mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu80.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu80mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu90.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu90mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu91.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu91mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu92.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_cu92mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
3 changes: 0 additions & 3 deletions make/pip/pip_linux_mkl.mk
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ DEV = 0
# whether compile with debug
DEBUG = 0

# whether compiler with profiler
USE_PROFILER = 1

# whether to turn on signal handler (e.g. segfault logger)
USE_SIGNAL_HANDLER = 1

Expand Down
1 change: 0 additions & 1 deletion tests/jenkins/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ cp make/config.mk .
echo "USE_CUDA=1" >> config.mk
echo "USE_CUDA_PATH=/usr/local/cuda" >> config.mk
echo "USE_CUDNN=1" >> config.mk
echo "USE_PROFILER=1" >> config.mk
echo "DEV=1" >> config.mk
echo "EXTRA_OPERATORS=example/ssd/operator" >> config.mk
echo "USE_CPP_PACKAGE=1" >> config.mk
Expand Down
1 change: 0 additions & 1 deletion tests/jenkins/run_test_ubuntu.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ cp make/config.mk .
echo "USE_CUDA=1" >> config.mk
echo "USE_CUDA_PATH=/usr/local/cuda" >> config.mk
echo "USE_CUDNN=1" >> config.mk
echo "USE_PROFILER=1" >> config.mk
echo "DEV=1" >> config.mk
echo "EXTRA_OPERATORS=example/ssd/operator" >> config.mk
echo "USE_CPP_PACKAGE=1" >> config.mk
Expand Down