-
Notifications
You must be signed in to change notification settings - Fork 6.8k
julia: rename build env var MXNET_HOME
to MXNET_ROOT
#15568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this is great to clarify environment variables. Does this introduce some backwards incompatibility for any users? I wonder if we should hold this kind of change for a minor release... like 1.6.
That way, my patch can go in and we can resume publishing the website.
If we continue to have issues, or if we go through testing on this PR and update my PR to use the new env var MXNET_ROOT, I'll want to disable Julia docs in settings.ini
in another PR, so we can get the website back to publishing regularly.
I can make it backward compatible in this PR, and your PR will work fine. |
okay, I added backward compatibility. |
be780c5
to
409ce0e
Compare
okay, the build of 409ce0e looks fine. |
ea65f51
to
f1a36fb
Compare
@iblis17 Can you resolve the merge conflicts and take this PR forward ? |
…net into ib/jl-mxnet-root-env
@iblis17 Hi Iblis, I'd like to revert this change since it caused the website to stop publishing. |
…che#15568)" This reverts commit 75ee1e9.
oh, @aaronmarkham what are the recent changes on the website builds? |
The code isn't merged yet, but we're close. Info is here: https://cwiki.apache.org/confluence/display/MXNET/Building+the+New+Website Basically, with the new flow, after you've generated the MXNet binary (with a similar single command), you can run this to test the Julia docs build. Then you don't have to worry about Sphinx or any other dependency than the MXNet binary and just focus on Julia.
|
* julia: rename build env var `MXNET_HOME` to `MXNET_ROOT` - Add MXNET_LIBRARY_PATH support Ref: apache#15561 * backward compatibility
…che#15568)" (apache#16147) This reverts commit 75ee1e9.
MXNET_LIBRARY_PATH
supportRef: #15561